Skip to content

Improve preformance of TestCase.subTest() in python 3.10 #13970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve preformance of TestCase.subTest() in python 3.10 #13970

wants to merge 1 commit into from
+190 −17

Conversation

@AkaZecik
Copy link

@AkaZecik AkaZecik commented Nov 16, 2025

Fixes #13965

nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Nov 21, 2025
@nicoddemus
Fix quadratic-time behavior when handling unittest subtests in Pyth…
7e2edcf 
…on 3.10

Fix pytest-dev#13965
Close pytest-dev#13970
@nicoddemus nicoddemus mentioned this pull request Nov 21, 2025
Merged
@nicoddemus
Copy link
Member

nicoddemus commented Nov 21, 2025

Thanks a lot for the report and PR @AkaZecik, appreciate it.

Found a simpler solution in #13993, we can cache the errors and skips in TestCaseFunction itself.

patchback bot pushed a commit that referenced this pull request Nov 22, 2025
@nicoddemus @patchback
Fix quadratic-time behavior when handling unittest subtests in Pyth…
741314a 
…on 3.10 (#13993)

Fix #13965
Close #13970

(cherry picked from commit 342dba6)
@patchback patchback bot mentioned this pull request Nov 22, 2025
Merged
nicoddemus added a commit that referenced this pull request Nov 22, 2025
@patchback @nicoddemus
Fix quadratic-time behavior when handling unittest subtests in Pyth…
c60fbe6 
…on 3.10 (#13993) (#13998)

Fix #13965
Close #13970

(cherry picked from commit 342dba6)

Co-authored-by: Bruno Oliveira <[email protected]>
pull bot pushed a commit to MaxMood96/pytest that referenced this pull request Nov 22, 2025
@nicoddemus
Fix quadratic-time behavior when handling unittest subtests in Pyth…
342dba6 
…on 3.10 (pytest-dev#13993)

Fix pytest-dev#13965
Close pytest-dev#13970
@AkaZecik AkaZecik deleted the fast-testcase-subtests branch November 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quadratic blowup when using TestCase subtests in python 3.10

2 participants

@AkaZecik @nicoddemus